Skip to content

tests: fix deprecation from PHPUnit#1217

Draft
Chris53897 wants to merge 3 commits intogeocoder-php:masterfrom
Chris53897:feature/fix-warning-for-tests
Draft

tests: fix deprecation from PHPUnit#1217
Chris53897 wants to merge 3 commits intogeocoder-php:masterfrom
Chris53897:feature/fix-warning-for-tests

Conversation

@Chris53897
Copy link
Contributor

@Chris53897 Chris53897 commented Mar 2, 2024 

There was 1 warning:

1) Geocoder\Provider\GeoIP2\Tests\GeoIP2AdapterTest::testReaderResponseIsJsonEncoded
assertObjectHasAttribute() is deprecated and will be removed in PHPUnit 10. Refactor your test to use assertObjectHasProperty() instead.

@jbelien jbelien added the on hold label Mar 2, 2024
@jbelien jbelien marked this pull request as draft March 2, 2024 11:09
@jbelien
Copy link
Member

jbelien commented Mar 2, 2024 •
edited
Loading

That breaks all "(low)" checks. I would wait until we upgrade to PHPUnit 10 before making that change.

@Chris53897
Copy link
Contributor Author

Chris53897 commented Mar 2, 2024

This is maybe solved by #1218 with Raising minimum PHPUnit version to 9.6 (or 9.6.x)

@Chris53897
Copy link
Contributor Author

Chris53897 commented Mar 2, 2024

Bumping the minium PHPUnit version, solved this problem.
But of course this is up to you, to wait until PHPUnit 10+.

@Chris53897 Chris53897 force-pushed the feature/fix-warning-for-tests branch from d745584 to 44cec07 Compare September 26, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

on hold

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Chris53897 @jbelien @Chris8934